Feature gate for defaulted associated type_consts with associated_type_defaults by LaneAsade · Pull Request #152385 · rust-lang/rust

LaneAsade · 2026-02-09T13:14:18Z

This PR for issue #130288 extends a feature gate that was already present for defaulted associated types to defaulted type consts under associated_type_defaults.

Code added:

if ctxt == AssocCtxt::Trait && rhs.is_some() {
                    gate!(
                        &self,
                        associated_type_defaults,
                        i.span,
                        "associated type defaults are unstable"
                    );
                }

Error produced:

error[E0658]: associated type defaults are unstable
  --> $DIR/type-const-associated-default.rs:4:5
   |
LL |     type const N: usize = 10;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #29661 <https://github.com/rust-lang/rust/issues/29661> for more information
   = help: add `#![feature(associated_type_defaults)]` to the crate attributes to enable
   = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date

warning: the feature `min_generic_const_args` is incomplete and may not be safe to use and/or cause compiler crashes
  --> $DIR/type-const-associated-default.rs:1:12
   |
LL | #![feature(min_generic_const_args)]
   |            ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: see issue #132980 <https://github.com/rust-lang/rust/issues/132980> for more information
   = note: `#[warn(incomplete_features)]` on by default

error: aborting due to 1 previous error; 1 warning emitted

For more information about this error, try `rustc --explain E0658`.

Thanks to @BoxyUwU for the guidance on this issue.

rustbot · 2026-02-09T13:14:24Z

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 21 candidates
Random selection from 13 candidates

BoxyUwU · 2026-02-09T13:26:27Z

r? BoxyUwU

tests/ui/feature-gates/type-const-associated-default.rs

compiler/rustc_ast_passes/src/feature_gate.rs

tests/ui/feature-gates/type-const-associated-default.rs

rustbot · 2026-02-12T13:32:44Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

BoxyUwU · 2026-02-14T19:33:19Z

@rustbot author

rustbot · 2026-02-14T19:33:23Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-02-15T17:41:58Z

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

LaneAsade · 2026-02-15T20:56:58Z

@rustbot ready

LaneAsade · 2026-02-18T20:14:49Z

@BoxyUwU hey, just checking in on the status of the PR. Are there any issues with it that I need to resolve or is it all good?

fmease

Could you please squash all 10 commits into a single one? Thanks!

View changes since this review

tests/ui/const-generics/mgca/type-const-associated-default.rs

BoxyUwU · 2026-02-18T22:35:07Z

fmease's reviews are good 😌 we can merge after they're dealt with :)

LaneAsade · 2026-02-19T06:09:14Z

Is this fine? Anything else to be done?

fmease · 2026-02-22T15:44:58Z

As per

fmease's reviews are good 😌 we can merge after they're dealt with :)

@bors r=BoxyUwU rollup

rust-bors · 2026-02-22T15:45:01Z

📌 Commit 84140cf has been approved by BoxyUwU

It is now in the queue for this repository.

@BoxyUwU

…, r=BoxyUwU Feature gate for defaulted associated type_consts with associated_type_defaults *[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152385)* This PR for issue rust-lang#130288 extends a feature gate that was already present for defaulted associated types to defaulted type consts under associated_type_defaults. Code added: ``` if ctxt == AssocCtxt::Trait && rhs.is_some() { gate!( &self, associated_type_defaults, i.span, "associated type defaults are unstable" ); } ``` Error produced: ``` error[E0658]: associated type defaults are unstable --> $DIR/type-const-associated-default.rs:4:5 | LL | type const N: usize = 10; | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: see issue rust-lang#29661 <rust-lang#29661> for more information = help: add `#![feature(associated_type_defaults)]` to the crate attributes to enable = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date warning: the feature `min_generic_const_args` is incomplete and may not be safe to use and/or cause compiler crashes --> $DIR/type-const-associated-default.rs:1:12 | LL | #![feature(min_generic_const_args)] | ^^^^^^^^^^^^^^^^^^^^^^ | = note: see issue rust-lang#132980 <rust-lang#132980> for more information = note: `#[warn(incomplete_features)]` on by default error: aborting due to 1 previous error; 1 warning emitted For more information about this error, try `rustc --explain E0658`. ``` Thanks to @BoxyUwU for the guidance on this issue.

…uwer Rollup of 3 pull requests Successful merges: - #152385 (Feature gate for defaulted associated type_consts with associated_type_defaults ) - #152921 (Add build.rustdoc option to bootstrap config) - #152926 (Fix ICE when an associated type is wrongly marked as `final`)

@BoxyUwU

…, r=BoxyUwU Feature gate for defaulted associated type_consts with associated_type_defaults *[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152385)* This PR for issue rust-lang#130288 extends a feature gate that was already present for defaulted associated types to defaulted type consts under associated_type_defaults. Code added: ``` if ctxt == AssocCtxt::Trait && rhs.is_some() { gate!( &self, associated_type_defaults, i.span, "associated type defaults are unstable" ); } ``` Error produced: ``` error[E0658]: associated type defaults are unstable --> $DIR/type-const-associated-default.rs:4:5 | LL | type const N: usize = 10; | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: see issue rust-lang#29661 <rust-lang#29661> for more information = help: add `#![feature(associated_type_defaults)]` to the crate attributes to enable = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date warning: the feature `min_generic_const_args` is incomplete and may not be safe to use and/or cause compiler crashes --> $DIR/type-const-associated-default.rs:1:12 | LL | #![feature(min_generic_const_args)] | ^^^^^^^^^^^^^^^^^^^^^^ | = note: see issue rust-lang#132980 <rust-lang#132980> for more information = note: `#[warn(incomplete_features)]` on by default error: aborting due to 1 previous error; 1 warning emitted For more information about this error, try `rustc --explain E0658`. ``` Thanks to @BoxyUwU for the guidance on this issue.

…uwer Rollup of 8 pull requests Successful merges: - #149366 (GVN: consider constants of primitive types as deterministic) - #152779 (Clarify aspects of query macros) - #152958 (`rustc_queries` simplifications) - #152385 (Feature gate for defaulted associated type_consts with associated_type_defaults ) - #152708 (Build: Add `stdenv.cc.cc.lib` to Nix dependencies) - #152921 (Add build.rustdoc option to bootstrap config) - #152926 (Fix ICE when an associated type is wrongly marked as `final`) - #152927 (Index expressions rendered the index: subexpression as the id, instea…)

…uwer Rollup of 7 pull requests Successful merges: - #152779 (Clarify aspects of query macros) - #152958 (`rustc_queries` simplifications) - #152385 (Feature gate for defaulted associated type_consts with associated_type_defaults ) - #152708 (Build: Add `stdenv.cc.cc.lib` to Nix dependencies) - #152921 (Add build.rustdoc option to bootstrap config) - #152926 (Fix ICE when an associated type is wrongly marked as `final`) - #152927 (Index expressions rendered the index: subexpression as the id, instea…)

@BoxyUwU

Rollup merge of #152385 - LaneAsade:gate-type-const-defaults, r=BoxyUwU Feature gate for defaulted associated type_consts with associated_type_defaults *[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust/pull/152385)* This PR for issue #130288 extends a feature gate that was already present for defaulted associated types to defaulted type consts under associated_type_defaults. Code added: ``` if ctxt == AssocCtxt::Trait && rhs.is_some() { gate!( &self, associated_type_defaults, i.span, "associated type defaults are unstable" ); } ``` Error produced: ``` error[E0658]: associated type defaults are unstable --> $DIR/type-const-associated-default.rs:4:5 | LL | type const N: usize = 10; | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: see issue #29661 <#29661> for more information = help: add `#![feature(associated_type_defaults)]` to the crate attributes to enable = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date warning: the feature `min_generic_const_args` is incomplete and may not be safe to use and/or cause compiler crashes --> $DIR/type-const-associated-default.rs:1:12 | LL | #![feature(min_generic_const_args)] | ^^^^^^^^^^^^^^^^^^^^^^ | = note: see issue #132980 <#132980> for more information = note: `#[warn(incomplete_features)]` on by default error: aborting due to 1 previous error; 1 warning emitted For more information about this error, try `rustc --explain E0658`. ``` Thanks to @BoxyUwU for the guidance on this issue.

rustbot assigned TaKO8Ki Feb 9, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 9, 2026

LaneAsade changed the title ~~Feature gate for defaulted associated type_consts with associated_type_defaults #130288~~ Feature gate for defaulted associated type_consts with associated_type_defaults Feb 9, 2026

rustbot assigned BoxyUwU and unassigned TaKO8Ki Feb 9, 2026

This comment has been minimized.

Sign in to view

BoxyUwU reviewed Feb 10, 2026

View reviewed changes

tests/ui/feature-gates/type-const-associated-default.rs Outdated Show resolved Hide resolved

BoxyUwU reviewed Feb 10, 2026

View reviewed changes

compiler/rustc_ast_passes/src/feature_gate.rs Outdated Show resolved Hide resolved

BoxyUwU reviewed Feb 10, 2026

View reviewed changes

tests/ui/feature-gates/type-const-associated-default.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2026

This comment has been minimized.

Sign in to view

LaneAsade force-pushed the gate-type-const-defaults branch from 1867a9d to f85e72b Compare February 12, 2026 13:32

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2026

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2026

This comment has been minimized.

Sign in to view

rustbot added the PG-exploit-mitigations Project group: Exploit mitigations label Feb 15, 2026

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 15, 2026

fmease reviewed Feb 18, 2026

View reviewed changes

tests/ui/const-generics/mgca/type-const-associated-default.rs Outdated Show resolved Hide resolved

gate defaulted type consts with associated_type_defaults

84140cf

LaneAsade force-pushed the gate-type-const-defaults branch from 02fca73 to 84140cf Compare February 19, 2026 04:40

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2026

fmease mentioned this pull request Feb 22, 2026

Support assoc type defaults for assoc type constraints of trait objects #152959

Open

JonathanBrouwer mentioned this pull request Feb 22, 2026

Rollup of 3 pull requests #152979

Closed

JonathanBrouwer mentioned this pull request Feb 22, 2026

Rollup of 8 pull requests #152982

Closed

JonathanBrouwer mentioned this pull request Feb 22, 2026

Rollup of 7 pull requests #152986

Merged

rust-bors bot merged commit 3880323 into rust-lang:main Feb 22, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 22, 2026

LaneAsade deleted the gate-type-const-defaults branch February 22, 2026 23:01

Uh oh!

Comments

Conversation

LaneAsade commented Feb 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 9, 2026

Uh oh!

BoxyUwU commented Feb 9, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Feb 12, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

BoxyUwU commented Feb 14, 2026

Uh oh!

rustbot commented Feb 14, 2026

Uh oh!

This comment has been minimized.

rustbot commented Feb 15, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

LaneAsade commented Feb 15, 2026

Uh oh!

LaneAsade commented Feb 18, 2026

Uh oh!

fmease left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BoxyUwU commented Feb 18, 2026

Uh oh!

LaneAsade commented Feb 19, 2026

Uh oh!

fmease commented Feb 22, 2026

Uh oh!

rust-bors bot commented Feb 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LaneAsade commented Feb 9, 2026 •

edited by rustbot

Loading

fmease left a comment •

edited by rustbot

Loading